Skip to content

Introduce StrrevFunctionReturnTypeExtension #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Apr 21, 2025

Improves #3921

@VincentLanglet VincentLanglet marked this pull request as ready for review April 21, 2025 21:23
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

{
$args = $functionCall->getArgs();
if (count($args) < 1) {
return new StringType();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return null instead

return new IntersectionType($accessoryTypes);
}

return new StringType();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return null instead

@ondrejmirtes ondrejmirtes merged commit 94a6678 into phpstan:1.12.x May 13, 2025
306 of 307 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants